[webview_flutter] Introduce webview_flutter base on chromium engine(ewk) #145
Conversation
bwikbs
force-pushed
the
webview_ewk
branch
6 times, most recently
from
06939f1 to
d030cf6
Compare
|
Question: What does "ewk" stand for? |
Oh. It stands for evas webkit (probably? ). This is prefix used in traditional tizen webview. |
|
There are so many diffs that I feel overwhelmed...If you don't mind, Could you split this PR into at least two or more? |
👌 Now, It only contains |
bwikbs
force-pushed
the
webview_ewk
branch
3 times, most recently
from
5297005 to
0e5e825
Compare
* Add webview_flutter_tizen_ewk Signed-off-by: MuHong Byun <mh.byun@samsung.com>
| @@ -0,0 +1,26 @@ | |||
| Copyright (c) 2020 Samsung Electronics Co., Ltd. All rights reserved. | |||
There was a problem hiding this comment.
| Copyright (c) 2020 Samsung Electronics Co., Ltd. All rights reserved. | |
| Copyright (c) 2021 Samsung Electronics Co., Ltd. All rights reserved. |
|
|
||
| This plugin is available on these types of devices: | ||
|
|
||
| - Galaxy Watch or TV (running Tizen 5.5 or later) |
There was a problem hiding this comment.
In my opinion, unlike LWE, 4.0 or later is enough to support webview_flutter_tizen_ewk.
| dev_dependencies: | ||
| flutter_driver: | ||
| sdk: flutter | ||
| integration_test: ^1.0.1 |
There was a problem hiding this comment.
| integration_test: ^1.0.1 | |
| integration_test: | |
| sdk: flutter |
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest package="org.tizen.webview_flutter_tizen_ewk_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages"> | |||
There was a problem hiding this comment.
As mentioned earlier, if it is supported in version 4.0, it should be modified.
| <manifest package="org.tizen.webview_flutter_tizen_ewk_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages"> | |
| <manifest package="org.tizen.webview_flutter_tizen_ewk_example" version="1.0.0" api-version="4.0" xmlns="http://tizen.org/ns/packages"> |
| @@ -0,0 +1,871 @@ | |||
| // Copyright 2021 Samsung Electronics Co., Ltd. All rights reserved. | |||
There was a problem hiding this comment.
This file is the same as webview_flutter_tizen.dart.
IMO, we could add a new package for this common interface. Like a platform interface.
What do you think? Since big changes are expected, I think we can take time to discuss them slowly.
| class WebViewFactory : public PlatformViewFactory { | ||
| public: | ||
| WebViewFactory(flutter::PluginRegistrar* registrar, | ||
| flutter::TextureRegistrar* textureRegistrar); |
There was a problem hiding this comment.
| flutter::TextureRegistrar* textureRegistrar); | |
| flutter::TextureRegistrar* texture_registrar); |
|
|
|
The rootstrap of tizen sdk has the following headers. are these not enough to implement this plugin? ~/tizen-studio/platforms/tizen-4.0/mobile/rootstraps/mobile-4.0-device.core/usr/include/chromium-ewk $ tree
.
├── EWebKit.h
├── ewk_autofill_profile.h
├── ewk_back_forward_list.h
├── ewk_back_forward_list_item.h
├── ewk_context.h
├── ewk_context_menu.h
├── ewk_cookie_manager.h
├── ewk_error.h
├── ewk_geolocation.h
├── ewk_intercept_request.h
├── ewk_main.h
├── ewk_manifest.h
├── ewk_policy_decision.h
├── ewk_security_origin.h
├── ewk_settings.h
└── ewk_view.h
|
|
If Public APIs of ewk are not enough, it may be more appropriate to work with our internal repository. and, like our engine, it doesn't seem to be available in some app stores. |
|
Furthermore, IMHO, to use the internal API, it seems that we need to set up a private rootstrap(inhouse) and get support to use it in flutter-tizen. There are the necessary internal header files and .so |
|
After a long discussion, it was concluded that it would be better to develop this webview at in-house repository. |
Precondition
You need to copy the following headers from rootstrip, which is used for engine build, to sdk include path.Plan
(Probably
webview_flutter_tizenwill be deprecated?)