Clean up the embedder API and refactor #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
swift-kim
force-pushed
the
refactor-engine
branch
from
1299efb to
5a51f28
Compare
swift-kim
added a commit
that referenced
this pull request
Jun 7, 2021
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.1.4 to 1.1.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f5d8227...8834766) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Rename types and functions * Clean up engine APIs * Add FlutterDesktopEngineGetMessenger API * Refactor FlutterTizenEngine a bit * Refactor channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the Tizen embedder API and refactor some parts of the embedder.
APIs changed:
FluttertoFlutterDesktop(this has been discussed once before somewhere in the internal repo but I'd like to change it back to more verbose one to avoid ambiguity and for consistency with other plugin/texture APIs)FlutterEnginePropertiesis a Flutter embedder API (embedder.h) or Tizen API (flutter_tizen.h).FlutterDesktopEngineGetMessenger(for later use)FlutterCreateWindow,FlutterDestroyWindow,FlutterRunsPrecompiledCodeFlutterWindowControllerStateis replaced byFlutterDesktopEngineRef(because the name is not appropriate for headless mode)FlutterDesktopRunEnginetakes aboolparameterOther changes:
TizenEmbedderEnginetoFlutterTizenEngine(which is similar toFlutterWindowsEngine) and clean uprendererinstead oftizen_renderer)A follow-up PR will be made in the tool repo soon.
More refactoring should be done in the future. I mainly focused on cleaning up
flutter_tizen.ccandflutter_tizen_engine.hin this PR.