Fix a crash in ExternalTextureGL #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Abandon ownership of tbm surface in PopulateTextureWithIdentifier * This patch includes temporary fix for invalid tmb_surface Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Author
Author
|
@swift-kim if you don't mind, I want to include #80 |
bbrto21
force-pushed
the
fix_external_texture_gl
branch
from
f3c4c7f to
db57b57
Compare
xiaowei-guan
approved these changes
May 6, 2021
bbrto21
force-pushed
the
fix_external_texture_gl
branch
2 times, most recently
from
529bbe1 to
e1c4fc8
Compare
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
xuelian-bai
reviewed
May 6, 2021
| #ifndef WEARABLE_PROFILE | ||
| tbm_surface_internal_unref(tbm_surface); | ||
| #else | ||
| tbm_surface_destroy(tbm_surface); |
Author
There was a problem hiding this comment.
It reflects the current implementation that does not use ref/unref.
Member
There was a problem hiding this comment.
The current implementaion does not work tho.
Author
There was a problem hiding this comment.
@swift-kim You are right.
@swift-kim @xuelian-bai
if the cost of using map/unmap is high, I think using ref/unref is fine until find an alternative.
There was a problem hiding this comment.
maybe we can use the method to get the function pointer from libtbm.so.1
Member
There was a problem hiding this comment.
I didn't get it. You use media_packet instead of tbm surface, but how to generate texture by using media_packet?
Basically, we have to do same work which is performed by video or camera plug-in.. Code at #80 is just to show how change of interface will be... but the explanation seems to be insufficient.
I'll make a PR , so let's discuss whether it applies or not.
Author
There was a problem hiding this comment.
@bwikbs, @xuelian-bai
This PR fixes a crash and allows to use external textures in profiles other than wearable.
So, how about that we go to #82 for the discussion on how to create an external texture?
Author
There was a problem hiding this comment.
Could you merge this PR, if there is no issue other than things related to #82
Member
There was a problem hiding this comment.
That's a good idea. Shall we go to #82 for discussion regarding this?
xuelian-bai
reviewed
May 6, 2021
bbrto21
force-pushed
the
fix_external_texture_gl
branch
from
e1c4fc8 to
16b80f2
Compare
* Use find instead of operator[] that can cause unintended insertion Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bwikbs
reviewed
May 6, 2021
bwikbs
approved these changes
May 7, 2021
Merged
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * This patch includes temporary fix for invalid tmb_surface Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Include the texture id in the log Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * This patch includes temporary fix for invalid tmb_surface Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Include the texture id in the log Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * This patch includes temporary fix for invalid tmb_surface Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Include the texture id in the log Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * This patch includes temporary fix for invalid tmb_surface Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Include the texture id in the log Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * Include the texture id in the log * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * Include the texture id in the log * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * Include the texture id in the log * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * Include the texture id in the log * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * Include the texture id in the log * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Fix a crash in ExternalTextureGL * Abandon ownership of tbm surface in PopulateTextureWithIdentifier * Include the texture id in the log * Lock the mutex in the external texture related API * Use find instead of operator[] that can cause unintended insertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes :
Signed-off-by: Boram Bae boram21.bae@samsung.com