Implement TizenRendererEvasGL::SetGeometry #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
|
@HakkyuKim |
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
* It cannot pass our symbol checker(Tizne 4.0). Signed-off-by: Boram Bae <boram21.bae@samsung.com>
* Enable this feature when Tizen 5.5 or later becomes the default. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bbrto21
changed the title
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bwikbs
reviewed
Dec 2, 2021
|
|
||
| evas_object_image_size_set(graphics_adapter_, width, height); | ||
| gl_surface_ = evas_gl_surface_create(evas_gl_, gl_config_, width, height); | ||
| gl_resource_surface_ = evas_gl_pbuffer_surface_create(evas_gl_, gl_config_, |
There was a problem hiding this comment.
Have you tried without this? Because the last time I saw it, it didn't seem to be used much.
There was a problem hiding this comment.
Yes, it didn't work without this.
There was a problem hiding this comment.
Do you have a sample to test this PR?
There was a problem hiding this comment.
Please, see original PR : #201 (comment)
bwikbs
reviewed
Dec 3, 2021
| @@ -663,7 +663,11 @@ Evas_Object* TizenRendererEvasGL::SetupEvasWindow(int32_t* width, | |||
| efl_util_set_notification_window_level(evas_window_, | |||
| EFL_UTIL_NOTIFICATION_LEVEL_TOP); | |||
| } | |||
| // Please uncomment below and enable setWindowGeometry of window channel when | |||
| // Tizen 5.5 or later was chosen as default. | |||
| // elm_win_aux_hint_add(evas_window_, "wm.policy.win.user.geometry", "1"); | |||
There was a problem hiding this comment.
Is it only necessary for 5.5 and higher? I thought it was absolutely necessary
There was a problem hiding this comment.
elm_win_aux_hint_add is supported in Tizen 5.5 and later and Our symbol checker filters elm_win_aux_hint_add in Tizen 4.0.
So @swift-kim and I decided to comment it out and to keep that setWindowGeometry disabled on evas gl until Tizen 5.5 or later becomes our default.
There was a problem hiding this comment.
So elm_win_aux_hint_add(evas_window_, "wm.policy.win.user.geometry", "1") is required to configure window size?
There was a problem hiding this comment.
@HakkyuKim Yes, sorry for the late reply, I was on vacation.
7 tasks
HakkyuKim
approved these changes
Dec 9, 2021
swift-kim
reviewed
Dec 9, 2021
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
approved these changes
Dec 9, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl * Enable this feature when Tizen 5.5 or later becomes the default. * Cleanup minor things * Apply suggested changes Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl * Cleanup minor things * Apply suggested changes Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl * Cleanup minor things * Apply suggested changes Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl * Cleanup minor things * Apply suggested changes Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl * Cleanup minor things * Apply suggested changes Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Enable window channel on evas gl renderer * Fix x64 shell build break * Comment out elm_win_aux_hint_add related stuff * It cannot pass our symbol checker (Tizen 4.0). * Disable setWindowGeometry on evas gl Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boram Bae boram21.bae@samsung.com