This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Repository navigation
[in_app_purchase] Ensure purchases correctly report if they are acknowledged on Android - #4257
Merged
Merged
Conversation
renefloor
reviewed
Aug 24, 2021
Co-authored-by: Rene Floor <r.floor.1@gmail.com>
Co-authored-by: Rene Floor <r.floor.1@gmail.com>
cyanglaz
reviewed
Aug 24, 2021
| required String? transactionDate, | ||
| required this.billingClientPurchase, | ||
| required PurchaseStatus status, | ||
| bool pendingCompletePurchase = false, |
Contributor
There was a problem hiding this comment.
This looks like a public API change? The minor version should be updated.
Contributor
There was a problem hiding this comment.
Can modify it to be a non-public-API change if my below comment is applied.
Contributor
Author
There was a problem hiding this comment.
Done, thank you for the suggestion.
| verificationData: verificationData, | ||
| status: status, | ||
| ) { | ||
| this.pendingCompletePurchase = pendingCompletePurchase; |
Contributor
There was a problem hiding this comment.
Since we already have billingClientPurchase, can we just use it?
pendingCompletePurchase = !billingClientPurchase.isAcknowledged
So we don't need the extra pendingCompletePurchase parameter.
Contributor
Author
There was a problem hiding this comment.
You are 100% correct, thank you for this suggestion. I have committed the necessary changes.
mvanbeusekom
added
the
waiting for tree to go green
Contributor
Author
|
Merging this PR as the Windows Plugins tasks seem stuck and this plugin doesn't contain any windows related code which should make is save to merge as all other tasks are green. |
mvanbeusekom
added
needs-publishing
and removed
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2021
…re acknowledged on Android (flutter-team-archive/plugins#4257)
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 27, 2021
…re acknowledged on Android (flutter-team-archive/plugins#4257) (#89040)
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…wledged on Android (flutter-team-archive#4257) * Ensure purchases correctly show they are acknowledged * Update packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Co-authored-by: Rene Floor <r.floor.1@gmail.com> * Update packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Co-authored-by: Rene Floor <r.floor.1@gmail.com> * Modify so public API is not changed Co-authored-by: Rene Floor <r.floor.1@gmail.com>
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
…wledged on Android (flutter-team-archive#4257) * Ensure purchases correctly show they are acknowledged * Update packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Co-authored-by: Rene Floor <r.floor.1@gmail.com> * Update packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Co-authored-by: Rene Floor <r.floor.1@gmail.com> * Modify so public API is not changed Co-authored-by: Rene Floor <r.floor.1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android the indication if a purchase is completed (acknowledged) should be based on the
Purchase.isAcknowledged()method (see documentation) instead of thePurchaseState. As described in issue flutter/flutter#85448 determining if a purchase is completed based on the state results into a problem when purchases are restored. In this case the purchase status will have a value ofPurchaseStatus.restoredwhich doesn't indicate if a purchase is "purchased and not acknowledged" or "purchased and acknowledged". This leads to developers not being able to correctly determine if a purchase still needs to be completed.Resolves flutter/flutter#85448
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.