This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Repository navigation
Don't use 'flutter upgrade' on Cirrus - #4213
Merged
stuartmorgan-g merged 4 commits intoAug 4, 2021
Merged
Conversation
This command isn't intended for CI use, and is also slower due to downloading artifacts that will be immidately discarded. Cirrus portion of flutter/flutter#86037
jmagman
reviewed
Aug 2, 2021
jmagman
left a comment
Contributor
There was a problem hiding this comment.
@christopherfujino This looks right to me, can you think of any more gotchas to resetting since you're been conductoring?
christopherfujino
approved these changes
Aug 2, 2021
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM. The only difference under the hood between these commands and doing flutter upgrade is that the latter will also precache certain artifacts. However, the tool should ensure any necessary cache artifacts in the validation phase of any command (e.g. ios artifacts before flutter build ios), so this should be fine.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
This command isn't intended for CI use, and is also slower due to downloading artifacts that will be immidately discarded. Cirrus portion of flutter/flutter#86037
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
This command isn't intended for CI use, and is also slower due to downloading artifacts that will be immidately discarded. Cirrus portion of flutter/flutter#86037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command isn't intended for CI use, and is also slower due to
downloading artifacts that will be immidately discarded.
Cirrus portion of flutter/flutter#86037
Pre-launch Checklist
dart format.)[shared_preferences]///).