This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Repository navigation
Check in regenerated C++ example registrants - #4004
Merged
fluttergithubbot merged 1 commit intoJun 2, 2021
Merged
fluttergithubbot merged 1 commit into
fluttergithubbot merged 1 commit into
Conversation
The Flutter-generated C++ plugin registrants use a format that doesn't always match what this repo's clang-format settings wanted, so every time some of them were regenerated it created a local diff that couldn't be checked in without failing the CI format check. The templates are now generated with a directive to disable clang-format; this checks in that version of all of the files to avoid the local edit problem in the future.
gaaclarke
approved these changes
Jun 2, 2021
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 3, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flutter-generated C++ plugin registrants use a format that doesn't
match what this repo's clang-format settings wanted, so every time they
were regenerated it created a local diff that couldn't be checked in
without failing the CI format check.
The templates are now generated with a directive to disable
clang-format; this checks in that version of all of the files to avoid
the local edit problem in the future.
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.