Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Add iOS integration tests - #3995

Merged
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
jmagman:wvf-tests
Jun 2, 2021
Merged

[webview_flutter] Add iOS integration tests#3995
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
jmagman:wvf-tests

Conversation

@jmagman

@jmagman jmagman commented Jun 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Rename RunnerUITests -> RunnerTests since they weren't UI tests, they were actually unit (XCTest) tests.
  • Add RunnerUITests test target, and tests for the user agent and adding values to the cache.

webview_flutter part of flutter/flutter#83357

https://cirrus-ci.com/task/5192127203246080?logs=xctest#L1836

Test Suite 'RunnerTests.xctest' passed at 2021-06-01 13:55:51.632.
	 Executed 5 tests, with 0 failures (0 unexpected) in 0.374 (0.383) seconds
Test Suite 'All tests' passed at 2021-06-01 13:55:51.634.
	 Executed 5 tests, with 0 failures (0 unexpected) in 0.374 (0.385) seconds

Test Suite 'FLTWebViewUITests' passed at 2021-06-01 13:56:26.614.
	 Executed 2 tests, with 0 failures (0 unexpected) in 31.097 (31.098) seconds
Test Suite 'RunnerUITests.xctest' passed at 2021-06-01 13:56:26.615.
	 Executed 2 tests, with 0 failures (0 unexpected) in 31.097 (31.100) seconds

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Jun 1, 2021
@google-cla google-cla Bot added the cla: yes label Jun 1, 2021
jmagman
jmagman commented Jun 1, 2021
View reviewed changes
Comment thread packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Comment on lines -406 to -420
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
CLANG_ENABLE_OBJC_WEAK = YES;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
CODE_SIGN_STYLE = Automatic;
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = RunnerUITests/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 13.2;
INFOPLIST_FILE = RunnerTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = "com.google.webview-flutter-exampleTests";
PRODUCT_NAME = "$(TARGET_NAME)";
TARGETED_DEVICE_FAMILY = "1,2";

@jmagman jmagman Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test target build settings didn't need to be overridden from the project-level build settings.

Comment thread ...s/webview_flutter/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/RunnerUITests.xcscheme
@@ -1,52 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>

@jmagman jmagman Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scheme is unnecessary, the CI tests use the test action of the Runner scheme (which runs the UI and unit tests).

@github-actions github-actions Bot added the p: webview_flutter Edits files for a webview_flutter plugin label Jun 1, 2021
@jmagman
jmagman requested a review from stuartmorgan-g June 2, 2021 00:45
stuartmorgan-g
stuartmorgan-g approved these changes Jun 2, 2021
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@fluttergithubbot
fluttergithubbot merged commit 9a9f3d8 into flutter-team-archive:master Jun 2, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
9a9f3d8 [webview_flutter] Add iOS integration tests (flutter-team-arc…
a1399db 
…hive/plugins#3995)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
9a9f3d8 [webview_flutter] Add iOS integration tests (flutter-team-arc…
a34265b 
…hive/plugins#3995) (#83791)
@jmagman
jmagman deleted the wvf-tests branch June 2, 2021 17:57
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
[webview_flutter] Add iOS integration tests (flutter-team-archive#3995)
dd10223
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

cla: yes p: webview_flutter Edits files for a webview_flutter plugin platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @stuartmorgan-g @fluttergithubbot