Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick-actions] Revert migrating integration tests to NNBD - #3967

Merged
stuartmorgan-g merged 1 commit into
flutter-team-archive:masterfrom
stuartmorgan-g:revert-quick-actions-nnbd-integration-tests
May 24, 2021
Merged

stuartmorgan-g merged 1 commit into
flutter-team-archive:masterfrom
stuartmorgan-g:revert-quick-actions-nnbd-integration-tests

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Contributor

Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (#3932)"
(commit a864de2) since it seems to have
broken XCUITests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (flutter-team-archive#3932)"
(commit a864de2) since it seems to have
broken XCUITests.

@mvanbeusekom mvanbeusekom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g

Copy link
Copy Markdown
Contributor Author

Landing on red to fix tree.

@stuartmorgan-g
stuartmorgan-g merged commit 52033ca into flutter-team-archive:master May 24, 2021
@stuartmorgan-g
stuartmorgan-g deleted the revert-quick-actions-nnbd-integration-tests branch May 24, 2021 15:11
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
…eam-archive#3967)

Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (flutter-team-archive#3932)"
(commit a864de2) since it seems to have
broken XCUITests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants