This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Repository navigation
[url_launcher] and [url_launcher_platform_interface] Fix tests broken my ChannelBuffers migration - #3966
Merged
Conversation
This test broke because it relies on implementation details that are no longer valid. We believe it is redundant with the test above it and the test in the interface package at this point.
...so we have to run the test using runAsync otherwise the future will never complete.
5 of 11 tasks
5 of 11 tasks
Contributor
|
Landing on red to fix the tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2021
…s broken my ChannelBuffers migration (flutter-team-archive/plugins#3966)
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 22, 2021
…s broken my ChannelBuffers migration (flutter-team-archive/plugins#3966) (#83152)
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
… my ChannelBuffers migration (flutter-team-archive#3966) * Remove redundant test. This test broke because it relies on implementation details that are no longer valid. We believe it is redundant with the test above it and the test in the interface package at this point. * ChannelBuffers is actually async ...so we have to run the test using runAsync otherwise the future will never complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #3965 and #3963:
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.