Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Add "Restore purchases" button to example App - #3945

Merged
mvanbeusekom merged 4 commits into
flutter-team-archive:masterfrom
Baseflow:issue/80863
Jun 3, 2021
Merged

[in_app_purchase] Add "Restore purchases" button to example App#3945
mvanbeusekom merged 4 commits into
flutter-team-archive:masterfrom
Baseflow:issue/80863

Conversation

@mvanbeusekom

@mvanbeusekom mvanbeusekom commented May 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add a "Restore purchase" app to the in_app_purchase example app instead of restoring purchases when initialising the app, so the example App conforms to the guidelines specified by Apple in their Restoring Purchased Products guidelines.

This PR also corrects a small mistake in one of the code snippets in the README.md.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mvanbeusekom
mvanbeusekom requested a review from LHLL as a code owner May 20, 2021 12:48
@google-cla google-cla Bot added the cla: yes label May 20, 2021
@mvanbeusekom mvanbeusekom changed the title [in_app_purchase] Fixed code snippet in README [in_app_purchase] Add "Restore purchases" button to example App May 20, 2021
cyanglaz
cyanglaz approved these changes Jun 2, 2021
View reviewed changes

@cyanglaz cyanglaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom mentioned this pull request Jun 2, 2021
Merged
10 of 11 tasks
@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@fluttergithubbot

fluttergithubbot commented Jun 2, 2021

Copy link
Copy Markdown

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build-ipas+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 3, 2021
@mvanbeusekom
mvanbeusekom merged commit b2dd320 into flutter-team-archive:master Jun 3, 2021
@mvanbeusekom
mvanbeusekom deleted the issue/80863 branch June 3, 2021 05:42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2021
@engine-flutter-autoroll
b2dd320 [in_app_purchase] Add "Restore purchases" button to example A…
78813fa 
…pp (flutter-team-archive/plugins#3945)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 3, 2021
@engine-flutter-autoroll
b2dd320 [in_app_purchase] Add "Restore purchases" button to example A…
320f277 
…pp (flutter-team-archive/plugins#3945) (#83866)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@mvanbeusekom @fotiDim
[in_app_purchase] Add "Restore purchases" button to example App (flut…
659e22a 
…ter-team-archive#3945)

* Fixed code snippet in README

* Added button to restore purchases

* Updated CHANGELOG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g
@LHLL LHLL Awaiting requested review from LHLL
1 more reviewer
@cyanglaz cyanglaz cyanglaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: in_app_purchase waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[in_app_purchases] restorePurchases alternative for IOS? [in-app-purchase] inconsistency between documentation and example code

4 participants

@mvanbeusekom @fluttergithubbot @cyanglaz @stuartmorgan-g