This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Repository navigation
[shared_preferences] Allow getInstance() to be reentrant - #1961
Merged
Merged
Conversation
collinjackson
changed the title
collinjackson
approved these changes
Aug 8, 2019
collinjackson
left a comment
collinjackson
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thank you.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a breaking change.
The rationale is that some apps call SharedPreferences.getInstance() from multiple widgets. If these calls come back to back before the map definition manages to come back from native, you end up getting different instances of SharedPreferences which is very very bad.