This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
[Linux] add MockSignalHandler for testing GObject signals - #32650
Merged
fluttergithubbot merged 2 commits intoApr 14, 2022
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
8 tasks done
jpnurmi
force-pushed
the
mock-signal-handler
branch
from
April 13, 2022 21:52
b94ef8b to
8fd30ea
Compare
This is a simple helper class that allows settings GMock expectations on GObject signals: ```c GObject* foo_object = ...; flutter::testing::MockSignalHandler foo_changed(foo_object, "changed"); EXPECT_SIGNAL(foo_changed).Times(1); foo_set_something(foo_object, ...); ```
jpnurmi
force-pushed
the
mock-signal-handler
branch
from
April 13, 2022 22:01
8fd30ea to
9cd5982
Compare
g_object_add_weak_pointer() does not assign the initial value
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Apr 14, 2022
Contributor
Author
|
Here's an example of matching and capturing signal arguments: AtkObject* child2_object = nullptr;
flutter::testing::MockSignalHandler2<gint, AtkObject*> child2_added(
root_object, "children-changed::add");
EXPECT_SIGNAL2(child2_added, ::testing::Eq(1), ::testing::A<AtkObject*>())
.WillOnce(::testing::SaveArg<1>(&child2_object)); |
chinmaygarde
approved these changes
Apr 14, 2022
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation step split off from #32618 that will eventually fix light
vs. dark theme detection on Linux (flutter/flutter#101438).
MockSignalHandleris a helper class that allows settings GMock expectationson
GObjectsignals:Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.