Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Sets focus before sending a11y focus event in Android" - #28092

Merged
zanderso merged 1 commit into
masterfrom
revert-27992-issues/79528
Aug 14, 2021
Merged

zanderso merged 1 commit into
masterfrom
revert-27992-issues/79528

Conversation

@zanderso

Copy link
Copy Markdown
Contributor

Reverts #27992

It looks like this change caused a failure in

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20android_semantics_integration_test/2203/overview

[android_semantics_integration_test] [STDOUT] stdout: [ +856 ms] 00:15 �[32m+1�[0m�[31m -1�[0m: AccessibilityBridge TextField password TextField has correct Android semantics �[1m�[31m[E]�[0m�[0m
[android_semantics_integration_test] [STDOUT] stdout: [        ]   Expected: AndroidSemanticsNode with className: android.widget.EditText with actions: [AndroidSemanticsAction.clearAccessibilityFocus, AndroidSemanticsAction.click, AndroidSemanticsAction.copy, AndroidSemanticsAction.setSelection, AndroidSemanticsAction.setText] with flag isEditable: true with flag isFocusable: true with flag isFocused: true with flag isPassword: true
[android_semantics_integration_test] [STDOUT] stdout: [        ]     Actual: AndroidSemanticsNode:<{flags: {isEditable: true, isEnabled: true, isDismissible: false, isCheckable: false, isChecked: false, isFocused: true, isLongClickable: false, isFocusable: true, isPassword: true}, id: 30, text: null, rect: {height: 144, width: 1080, bottom: 592.0, top: 544.0, left: 0.0, right: 360.0}, actions: [131072, 32768, 2097152, 16, 64], className: android.widget.EditText, liveRegion: 0, contentDescription: null}>
[android_semantics_integration_test] [STDOUT] stdout: [        ]      Which: Expected actions: [AndroidSemanticsAction.clearAccessibilityFocus, AndroidSemanticsAction.click, AndroidSemanticsAction.copy, AndroidSemanticsAction.setSelection, AndroidSemanticsAction.setText]
[android_semantics_integration_test] [STDOUT] stdout: [        ]             Actual actions: [AndroidSemanticsAction.accessibilityFocus, AndroidSemanticsAction.click, AndroidSemanticsAction.copy, AndroidSemanticsAction.setSelection, AndroidSemanticsAction.setText]
[android_semantics_integration_test] [STDOUT] stdout: [        ]             Unexpected: {AndroidSemanticsAction.accessibilityFocus}
[android_semantics_integration_test] [STDOUT] stdout: [        ]             Missing: {AndroidSemanticsAction.clearAccessibilityFocus}

Reverting this to get the Engine roll moving again.

@zanderso
zanderso merged commit b1ccc41 into master Aug 14, 2021
@zanderso
zanderso deleted the revert-27992-issues/79528 branch August 14, 2021 05:54
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 14, 2021
* c388bfa Roll Skia from 1049d8206120 to abe39f5cb932 (6 revisions) (flutter-team-archive/engine#28090)

* 5ba9ed5 [web] Clean up legacy Paragraph implementation (flutter-team-archive/engine#28050)

* b1ccc41 Revert "Sets focus before sending a11y focus event in Android (#27992)" (flutter-team-archive/engine#28092)

* 1af0a20 Roll Fuchsia Linux SDK from WoiEzs7XB... to 54i7Z2kLS... (flutter-team-archive/engine#28093)
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
* c388bfa Roll Skia from 1049d8206120 to abe39f5cb932 (6 revisions) (flutter-team-archive/engine#28090)

* 5ba9ed5 [web] Clean up legacy Paragraph implementation (flutter-team-archive/engine#28050)

* b1ccc41 Revert "Sets focus before sending a11y focus event in Android (flutter#27992)" (flutter-team-archive/engine#28092)

* 1af0a20 Roll Fuchsia Linux SDK from WoiEzs7XB... to 54i7Z2kLS... (flutter-team-archive/engine#28093)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants