This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
[ci.yaml] Fix open_jdk dep naming - #27776
Merged
fluttergithubbot merged 1 commit intoJul 29, 2021
Merged
Conversation
Contributor
Author
blasten
approved these changes
Jul 28, 2021
blasten
left a comment
There was a problem hiding this comment.
LGTM. definitely, good error messages are time savers. Ideally, they are actionable by anyone.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 29, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 29, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to match what's in flutter_deps, otherwise, we'll get the weird failure we saw. I'll update the module to give a more descriptive error.
flutter/flutter#86892
Pre-launch Checklist
writing and running engine tests.
///).