Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Code cleanup - #27766

Merged
ferhatb merged 21 commits into
flutter-team-archive:masterfrom
ferhatb:analysis_cleanup6
Jul 28, 2021
Merged

ferhatb merged 21 commits into
flutter-team-archive:masterfrom
ferhatb:analysis_cleanup6

Conversation

@ferhatb

@ferhatb ferhatb commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

Related issue:
flutter/flutter#86891

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ferhatb
ferhatb requested a review from mdebbar July 28, 2021 16:41
@flutter-dashboard flutter-dashboard Bot added the platform-web Code specifically for the web engine label Jul 28, 2021
@google-cla google-cla Bot added the cla: yes label Jul 28, 2021

@mdebbar mdebbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

final ui.Offset tangent = tangents[last];
if (SPath.nearlyEqual(lengthSquaredOffset(tangent), 0)) {
tangents.remove(last);
tangents.removeAt(last);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a bug?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the lint uncovered it.

@ferhatb
ferhatb merged commit d8a5f40 into flutter-team-archive:master Jul 28, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 28, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Development

Successfully merging this pull request may close these issues.

2 participants