Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix a typo in https://github.com/flutter/engine/pull/27311 - #27687

Merged
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
moko256:moko256_fix_typo_27311
Aug 5, 2021
Merged

fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
moko256:moko256_fix_typo_27311

Conversation

@moko256

@moko256 moko256 commented Jul 24, 2021 •

Copy link
Copy Markdown
Contributor

This PR fixes a typo from #27311.
#27311 (comment)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie

Hixie commented Jul 25, 2021

Copy link
Copy Markdown
Contributor

test-exempt: code refactor with no semantic change

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 5, 2021
@fluttergithubbot
fluttergithubbot merged commit c0e59bc into flutter-team-archive:master Aug 5, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes needs tests platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Development

Successfully merging this pull request may close these issues.

4 participants