Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CanvasKit final JS-interop clean-up - #19850

Merged
yjbanov merged 1 commit into
flutter-team-archive:masterfrom
yjbanov:js-interop-rest
Jul 17, 2020
Merged

CanvasKit final JS-interop clean-up#19850
yjbanov merged 1 commit into
flutter-team-archive:masterfrom
yjbanov:js-interop-rest

Conversation

@yjbanov

@yjbanov yjbanov commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

Description

Convert the remaining usage of JsObject in the CanvasKit backend to the new JS-interop. Remove the no longer necessary JsObject code.

Tests

This is covered by the existing CanvasKit tests, because the converted code is all initialization code, which is exercised by every test.

@yjbanov
yjbanov requested a review from harryterkelsen July 17, 2020 18:53
@auto-assign
auto-assign Bot requested a review from flar July 17, 2020 18:56
harryterkelsen
harryterkelsen approved these changes Jul 17, 2020
View reviewed changes

@harryterkelsen harryterkelsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! LGTM

@yjbanov
yjbanov merged commit e51642e into flutter-team-archive:master Jul 17, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
4e5b41c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
33351f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
c2fe694
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
ae03d1f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
198d8d3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
5dc444a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
2b59a1c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
625f9f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
a890d13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
fff600f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
5c994d9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
d4a7ece
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
bf56349
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
f1d4a31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
47608a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 23, 2020
@engine-flutter-autoroll
e51642e JS-interop clean-up (flutter-team-archive/engine#19850)
a93ad12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@flar flar Awaiting requested review from flar
1 more reviewer
@harryterkelsen harryterkelsen harryterkelsen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yjbanov @harryterkelsen @googlebot