Migrate to sound null safety

[adarsh-technocrat]

Description

• Migrate to sound null safety
• Bump up package version

[rgr]

Any news ?

[adarsh-technocrat]

Any news ?

yup! there is an attached PR that will resolve this issue :)

[rgr]

Great news ! Thanks @adarsh-technocrat. Hope it gets accepted soon!

[rgr]

@2534290808 could you accept the null safety PR please?

[joaovvrodrigues]

@adarsh-technocrat how add this in my project ?

flutter_icons:
git:
url: https://github.com/adarsh-technocrat/flutter-icons/tree/null-safety-migration

don't work here, Could you upload your changes to your project's main?

[adarsh-technocrat]

flutter_icons

Hey, @joaovvrodrigues I would prefer you to make a different branch for your null safety version!
here I will change the base branch to that null safety branch and then you can merge it =)

[rgr]

@adarsh-technocrat while waiting for your PR to be accepted did you succeed in importing your own branch into your project ? How do you do that ?

[adarsh-technocrat]

@adarsh-technocrat while waiting for your PR to be accepted did you succeed in importing your own branch into your project ? How do you do that ?

Sorry @LearningRaph I could not get you but as far as I could understand I just went through the series of steps for migrating this sample and package :-

1. Forked the official repo
2. Cloned the forked repo to my local machine
3. Created the different branch for the null safety migration eg here :- git branch null-safety-migration
4. Applied Migration in the null-safety-migration branch
5. Committed the changes
6. Pushed the branch to my forked repo
7. Finally Generated the PR.

Im not Sure @LearningRaph is this is the right Answer for your Question!

[rgr]

Nope :) I was wondering if you could use your fork in your flutter app. If we don't have news from the creator it would be a good option...

[adarsh-technocrat]

Ahh.. no @LearningRaph until and unless it is Publish to the pub. div I think we cannot use the null-safety version of this package :)

[joaovvrodrigues]

@adarsh-technocrat @LearningRaph
in fact you can, and that's what I'm trying to say,
If you move your changes to the project's Branch Master, you can use the package directly from git.

flutter_icons:
git:
url: https://github.com/adarsh-technocrat/flutter-icons

because you created a new branch, then we can't access it, it needs to be on the master, as far as I know.

[adarsh-technocrat]

@adarsh-technocrat @LearningRaph
in fact you can, and that's what I'm trying to say,
If you move your changes to the project's Branch Master, you can use the package directly from git.

flutter_icons:
git:
url: https://github.com/adarsh-technocrat/flutter-icons

because you created a new branch, then we can't access it, it needs to be on the master, as far as I know.

oooh got it @joaovvrodrigues thanks I'll do the changes right now =)

[adarsh-technocrat]

Hey, @joaovvrodrigues I merged the null-safety-migration branch to the master branch see now if you can access the null safety version!

[joaovvrodrigues]

It worked just fine! 🥇