Skip to content

Conversation

@tobrun
Copy link
Collaborator

@tobrun tobrun commented Jan 26, 2020

Closes ##119

This PR adds configuration for enabling/disabling:

  • SymbolManager#iconAllowOverlap
  • SymbolManager#iconIgnorePlacement
  • SymbolManager#textAllowOverlap
  • SymbolManager#textIgnorePlacement

These configurations apply to all symbols maitained by the given manager.

ezgif com-video-to-gif (9)

@tobrun tobrun added this to the future milestone Jan 26, 2020
@tobrun tobrun self-assigned this Jan 26, 2020
Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I was just wondering if we could include some documentation, like a link to this page to explain what these properties/methods do?

@TimothySealy
Copy link
Collaborator

I've implemented the configuration for the symbol manager on iOS. The SymbolManager#textIgnorePlacement now throws a FlutterMethodNotImplemented because the Annotation Extension package does not seem to expose this option. Opened an issue here: mapbox/mapbox-annotation-extension#66

@TimothySealy TimothySealy added ios and removed needs iOS labels Mar 6, 2020
@TimothySealy TimothySealy mentioned this pull request May 22, 2020
57 tasks
@m0nac0
Copy link
Collaborator

m0nac0 commented May 24, 2020

@tobrun @TimothySealy I've just added the documentation with the link and resolved the simple merge conflict, is this ready to be merged?

@TimothySealy
Copy link
Collaborator

@m0nac0 I think this PR is ready to be merged. The missing iOS textIgnorePlacement implementation is tracked in issue #293

@tobrun tobrun merged commit a3a4461 into master Jun 4, 2020
m0nac0 added a commit that referenced this pull request Jun 4, 2020
@fotiDim
Copy link

fotiDim commented Jun 5, 2020

I am getting compilation errors after this got merged:

Compiler message:
../lib/src/controller.dart:376:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#iconAllowOverlap', <String, dynamic>{
          ^^^^^^^^                                                      
../lib/src/controller.dart:383:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#iconIgnorePlacement', <String, dynamic>{
          ^^^^^^^^                                                      
../lib/src/controller.dart:390:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#textAllowOverlap', <String, dynamic>{
          ^^^^^^^^                                                      
../lib/src/controller.dart:397:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#textIgnorePlacement', <String, dynamic>{
          ^^^^^^^^                                                      
                                                                        
Compiler message:                                                       
../lib/src/controller.dart:376:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#iconAllowOverlap', <String, dynamic>{
          ^^^^^^^^                                                      
../lib/src/controller.dart:383:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#iconIgnorePlacement', <String, dynamic>{
          ^^^^^^^^                                                      
../lib/src/controller.dart:390:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#textAllowOverlap', <String, dynamic>{
          ^^^^^^^^                                                      
../lib/src/controller.dart:397:11: Error: The getter '_channel' isn't defined for the class 'MapboxMapController'.
 - 'MapboxMapController' is from 'package:mapbox_gl/mapbox_gl.dart' ('../lib/mapbox_gl.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named '_channel'.
    await _channel.invokeMethod('symbolManager#textIgnorePlacement', <String, dynamic>{
          ^^^^^^^^                                                      

@andrea689
Copy link
Collaborator

@fotiDim i fix this on #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants