Skip to content

Conversation

@Pierre-Monier
Copy link

Fix issue #1192

I add a method on the MapboxMapController to display a popup when features of a given layer are hovered.

The method is named showPopupOnFeatureHover and it only does stuff if we are on the web, i.e _mapboxGlPlatform is MapboxWebGlPlatform.

And all it does it to create a Popup object and pass it to a method on the MapboxWebGlPlatform to actually display/hide the popup when a feature is hovered/ stop being hovered.

This implementation doesn't change the MapboxGlPlatform interface, because it's only web related, so it shouldn't be in the interface.

The displayed text is retrieved from the geoJson data, at the key description , like this example

@Thematt69
Copy link

Hello @felix-ht, I saw you discussed this modification, is it possible to review? I have the same need as @Pierre-Monier

@stale
Copy link

stale bot commented Jan 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 28, 2023
@stale stale bot closed this Feb 4, 2023
@Thematt69
Copy link

Hello @tobrun, is it possible for you to look at this pull request?
I'm currently developing a Flutter app (mobile and web) and we're using quite a bit of functionality from this package.
I'll leave you the link to the site if you want to watch, https://qualite-riviere.lesagencesdeleau.fr/

Thanking you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants