Symbol data is null in onTap, symbol tap doesn't consume click event

[hussenIbrahim]

Hello
i have some problem
1 - the symbol's center is placed at the target not the bottom edge of it
2 - on symbol tap i get null data
3 - on symbol tap also onMapClick is triggered
4 - symbol draggable is not working

  MapboxMapController mapController;

  void _onMapCreated(MapboxMapController controller) {
    mapController = controller;
    addImageFromAsset();
    mapController.onSymbolTapped.add((argument) {
      _onSymbolTapped(argument);
    });
  }

  Future<void> addImageFromAsset() async {
    final ByteData bytes = await rootBundle.load("assets/marker.png");
    final Uint8List list = bytes.buffer.asUint8List();
    return mapController.addImage("marker", list);
  }

  void _add() {
  
      final map = {'data': "data is "};
      mapController.addSymbol(_getSymbolOptions("marker"), map);
    
  }

  void _onSymbolTapped(Symbol symbol) {
    print(symbol.data);
  }


  SymbolOptions _getSymbolOptions(String iconImage) {
    return SymbolOptions(
        draggable: true,
        iconSize: 0.5,
        geometry: LatLng(0.0,0.0),
        iconImage: iconImage,
        zIndex: 1);
  }


//in scaffold body
 MapboxMap(
          onMapClick: (point, coordinates) {
            print(point);
            print(coordinates);
          },
          compassEnabled: false,
          myLocationEnabled: true,
          onMapCreated: _onMapCreated,
          initialCameraPosition: const CameraPosition(
              target: LatLng(0, 0), zoom: 15),
        )

[m0nac0]

@hussenIbrahim Thank you for reporting it.
1 This is the expected behaviour, you can specify the iconOffset in SymbolOptions to adjust the symbol's position.
2 & 3 are indeed bugs
4 is a known issue on Android, tracked at #130, it's an issue with the Mapbox SDK upstream (tracked there at mapbox/mapbox-plugins-android#863)

Could you also tell us what version of the plugin and flutter you're using and on which platform these bugs occur, please?

[hussenIbrahim]

Flutter 1.19.0-4.0pre
plugin version 0.7.0
Android platform

[m0nac0]

@hussenIbrahim I haven't been able to reproduce 2.
I did some research regarding 3 and this has been fixed upstream (see mapbox/mapbox-plugins-android#1124), so we'll have to wait for the next release of the Annotation plugin.

I've got the same issues (2 & 3).
Regarding (2), I confirm that addSymbol() with a data payload always results to null data while iterating over MapboxMapController.symbols.

$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, 1.19.0-4.1.pre, on Microsoft Windows [Version 10.0.18363.900], locale en-US)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 3.6)
[√] VS Code (version 1.46.1)
[√] Connected device (3 available)

• No issues found!

environment:
  sdk: ">=2.7.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.3

  mapbox_gl: ^0.7.0
  location: ^3.0.0
  provider: ^4.0.5
  wakelock:
  geodesy:
  uuid:
  bloc: ^4.0.0
  flutter_bloc: ^4.0.0
  equatable:

dev_dependencies:
  flutter_test:
    sdk: flutter

Example :

void _loadLayers() {
    _map.symbols.forEach((symbol) => _map.removeSymbol(symbol));
    widget.layers.forEach((layer) {
      layer.symbols.forEach((layerSymbol) {
        print({
          'layer': layer.name,
          'id': layerSymbol.id,
        }); // ***** output is ok *****
        _map.addSymbol(layerSymbol.options, {
          'layer': layer.name,
          'id': layerSymbol.id,
        }).whenComplete(() {
          _map.symbols.forEach((_) => print(_.data));  // ***** output is always null *****
        });
      });
    });
  }

[luiscavanillas]

Regarding 2: addSymbol() function does not use [this.data] parameter at all. It is actually skipped (not implemented).

By comparing mapbox 0.7.0 plugin and the mapbox example code you can see that "data" is only assigned to the symbol in the second one.

[m0nac0]

@luiscavanillas @saily-io @hussenIbrahim Could you please try using the latest version from Github with this dependency in pubspec.yaml:

mapbox_gl:
  git:
    url: https://github.com/tobrun/flutter-mapbox-gl.git

I think this should be fixed on master.

[luiscavanillas]

@m0nac0 Just did and it works.

[hussenIbrahim]

@luiscavanillas @saily-io @hussenIbrahim Could you please try using the latest version from Github with this dependency in pubspec.yaml:

mapbox_gl:
  git:
    url: https://github.com/tobrun/flutter-mapbox-gl.git

I think this should be fixed on master.

[TimothySealy]

As I understand it the status of these this issue is:

1. Expected behaviour (the symbol's center is placed at the target not the bottom edge of it)
2. Resolved in master (on symbol tap i get null data)
3. Fixed upstream waiting on release (on symbol tap also onMapClick is triggered)
4. Duplicate of Symbol draggable not working #130 (symbol draggable is not working)

Can we may close this issue and open a separate one for tracking nr 3?

[m0nac0]

@TimothySealy Sounds good. I haven't tested this but I think data will likely also be null for circles and lines right now, as the data parameter is ignored here:
https://github.com/tobrun/flutter-mapbox-gl/blob/4ce26231f3250b598060063d1b8b65950694754e/lib/src/controller.dart#L507-L515
This was only fixed for symbols with the symbol batch editing. So we might want to track that as well.