Skip to content

Conversation

@kNoAPP
Copy link

@kNoAPP kNoAPP commented May 14, 2024

Connection with issue(s)

Close #92
Close #91
Close #90

Solution description

Upgrades the intl package to 0.19.0 so that Flutter SDK v3.22.0 is supported.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link
Contributor

@deandreamatias deandreamatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need increase the flutter and dart minimum version, to avoid conflict with old version off Flutter

@kNoAPP kNoAPP requested a review from deandreamatias May 15, 2024 23:46
@NinoBass
Copy link

How soon can this be merged please? @deandreamatias

@deandreamatias
Copy link
Contributor

deandreamatias commented May 16, 2024

Had some error that isn't related to the intl dependency but with increase flutter version (I guess).
https://github.com/flutter-form-builder-ecosystem/form_builder_validators/actions/runs/9104136037/job/25067818196?pr=93

Take a look if can solve please. Will be awesome if you can.

@roskakori
Copy link

@deandreamatias It seems the project is using gradle 6.7. When running a flotter create xxx with the current Flutter 3.22, it uses gradle 7.6.3.

Possibly upgrading the gradle included in the project fixes this. You can try the instructions at Android Java Gradle migration guide which would come down to:

cd android
./gradlew wrapper --gradle-version=7.6.3

My personal experience with upgrading gradle in an existing Flutter project has been sketchy. What eventually fixed it for me was to

cd /tmp
flutter create form_builder_validators

and then just copy the /tmp/form_builder_validators/android folder over the existing project's android folder. If you previously modified any files in the project's android folder (e.g. adding properties), you will need to repeat these modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants