Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need visual density option in grouped_checkbox #1284

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

nicks258
Copy link
Contributor

@nicks258 nicks258 commented Aug 24, 2023

Connection with issue(s)

Close: #1283

Solution description

Added Visual density parameter and passed through FormBuilderCheckboxGroup

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link
Collaborator

@deandreamatias deandreamatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for contribution.
Please format code

lib/src/fields/form_builder_checkbox_group.dart Outdated Show resolved Hide resolved
@nicks258
Copy link
Contributor Author

I am not able to see my commits in main branch. Can you please check. @deandreamatias

@deandreamatias
Copy link
Collaborator

@nicks258 Please format code

@nicks258
Copy link
Contributor Author

But I already formatted my code to make visualDensity optional argument.

@deandreamatias
Copy link
Collaborator

@nicks258 you can see in the failed pipeline, that need format two files:
Screenshot 2023-09-21 at 11 28 59

To solve this, go to your fork project, execute dart format --set-exit-if-changed . and commit the changes

@nicks258
Copy link
Contributor Author

Thanks for your message. I formatted my code and pushed.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1284 (9900591) into main (4e16275) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
+ Coverage   84.96%   84.98%   +0.02%     
==========================================
  Files          21       21              
  Lines         725      726       +1     
==========================================
+ Hits          616      617       +1     
  Misses        109      109              
Files Changed Coverage Δ
lib/src/fields/form_builder_checkbox_group.dart 92.30% <ø> (ø)
lib/src/widgets/grouped_checkbox.dart 75.00% <100.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit e6b1059 into flutter-form-builder-ecosystem:main Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to control vertical space in FormBuilderCheckboxGroup
3 participants