Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve disabled decoration field form #1261

Merged
merged 1 commit into from
May 24, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented May 24, 2023

Connection with issue(s)

Close #1259

Solution description

  • Remove readonly property to enable decoration fields

Screenshots or Videos

Screenshot 2023-05-24 at 09 24 26

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1261 (c1fd0ac) into main (96eb532) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1261   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files          20       20           
  Lines         705      705           
=======================================
  Hits          601      601           
  Misses        104      104           
Impacted Files Coverage Δ
lib/src/form_builder_field_decoration.dart 84.61% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 01ec8bb into main May 24, 2023
@deandreamatias deandreamatias deleted the fix-1259-disabled-fields branch May 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderDropdown]: <Enable props>
1 participant