Skip to content

Fix Docker Build/Run Issues #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2023
Merged

Fix Docker Build/Run Issues #6

merged 3 commits into from
Oct 19, 2023

Conversation

aaj3f
Copy link
Collaborator

@aaj3f aaj3f commented Oct 19, 2023 •
edited
Loading

A few changes here

  • Dockerfile used wrong artifact names so that the ENTRYPOINT failed on docker run
  • config.edn needed a :docker profile value for consensus-this-server
  • (it looks like my Makefile suggestions for docker-build, docker-run, and docker-push made their way in here somehow!) docker-build needed a --load flag to make it into a local machine's image repository

zonotope
zonotope approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@zonotope zonotope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛵

@aaj3f aaj3f merged commit 1d24a3f into main Oct 19, 2023
@aaj3f aaj3f deleted the task/prep-docker-usage branch October 19, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonotope zonotope zonotope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaj3f @zonotope