Use hopefully soon-to-be-official cljfmt lib entrypoint #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @cap10morgan and the rest of your teammates on |
zonotope
approved these changes
Apr 26, 2024
bb/lib/cljfmt.clj
Outdated
| @@ -11,8 +11,9 @@ | |||
| "Runs cljfmt check on all files (recursively) in dir. Returns a collection of | |||
| any files that failed the check." | |||
| [dir] | |||
| (let [cljfmt-opts {:paths [dir], :diff? false} | |||
| {:keys [counts incorrect error] :as _result} (fmt/check cljfmt-opts)] | |||
| (let [cljfmt-opts {:diff? false} | |||
There was a problem hiding this comment.
this isn't involved in this pr, but is this option to display a diff in the output? if that's the case, that seems helpful.
There was a problem hiding this comment.
It is, but I think in practice it's much more noise than signal. It still outputs messages saying where the problem is and a description of the specific problem, and that's always been more than sufficient for me to know what I need to do to fix it.
Here's an example:
clj-kondo lint:
src/fluree/server/consensus.clj:12:19-25::warning - unused binding thingy
cap10morgan
force-pushed
the
04-25-use_hopefully_soon-to-be-official_cljfmt_lib_entrypoint
branch
from
1a1ef5e to
a0732c2
Compare
Merge activity
|
cap10morgan
deleted the
04-25-use_hopefully_soon-to-be-official_cljfmt_lib_entrypoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.