Skip to content

Allow environment variables in server configs #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jan 7, 2025
Merged

Conversation

zonotope
Copy link
Contributor

This patch removes the majority of the configuration processing and parsing code in favor of that added to the db library in fluree/db#943. The only configuration parsing and initialization code left here is that which is specific to fluree/server. This patch also makes use of the environment variable aware configuration parsing code added in fluree/db#943 so that users can specify that certain values should be loaded from environment variables.

@zonotope zonotope requested a review from a team November 28, 2024 20:00
Copy link
Contributor

@dpetran dpetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kurtharriger
Copy link
Contributor

Looks like user ns still references recently removed config methods causing the repl not to start for me
https://github.com/fluree/server/blob/feature/config-profiles/dev/src/user.clj#L14

@zonotope
Copy link
Contributor Author

zonotope commented Jan 7, 2025

Looks like user ns still references recently removed config methods causing the repl not to start for me https://github.com/fluree/server/blob/feature/config-profiles/dev/src/user.clj#L14

I've fixed this now.

@zonotope zonotope merged commit 073f1ee into main Jan 7, 2025
5 checks passed
@zonotope zonotope deleted the feature/config-profiles branch January 7, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants