-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/new fluree vocabulary #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
806408c
add a new vocabulary for fluree keywords
dpetran 9f37d70
add ledger keyword to fluree vocab
dpetran 6c4acde
handle empty arrays in json docs
dpetran 2be5f54
use same iris as old vocab
dpetran ac52ed8
add defaultContext to standard vocab
dpetran 63d14e7
allow user-supplied document loaders
dpetran b304104
remove currently unused vocab terms
dpetran 2b4a4cf
change fluree context url
dpetran 232408a
update docstrings
dpetran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{:protected true | ||
"ledger" {:id "https://ns.flur.ee/ledger#ledger"} | ||
"defaultContext" {:type :json :id "https://ns.flur.ee/ledger#defaultContext" } | ||
"delete" {:type :json :id "https://ns.flur.ee/ledger#delete"} | ||
"insert" {:type :json :id "https://ns.flur.ee/ledger#insert"} | ||
"opts" {:type :json :id "https://ns.flur.ee/ledger#opts"} | ||
"where" {:type :json :id "https://ns.flur.ee/ledger#where"} | ||
"values" {:type :json :id "https://ns.flur.ee/ledger#values"}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
"@context": { | ||
"@protected": true, | ||
"ledger": {"@id": "https://ns.flur.ee/ledger#ledger"}, | ||
"defaultContext": { | ||
"@type": "@json", | ||
"@id": "https://ns.flur.ee/ledger#defaultContext" | ||
}, | ||
"where": { | ||
"@type": "@json", | ||
"@id": "https://ns.flur.ee/ledger#where" | ||
}, | ||
"values": { | ||
"@type": "@json", | ||
"@id": "https://ns.flur.ee/ledger#values" | ||
}, | ||
"delete": { | ||
"@type": "@json", | ||
"@id": "https://ns.flur.ee/ledger#delete" | ||
}, | ||
"insert": { | ||
"@type": "@json", | ||
"@id": "https://ns.flur.ee/ledger#insert" | ||
}, | ||
"opts": { | ||
"@type": "@json", | ||
"@id": "https://ns.flur.ee/ledger#opts" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this missing a conclusion or a comma? In other words, does "and returns a json string..." apply to the document-loader (in which case this is missing a conclusion about what the fn itself returns / does) or to the fn itself (in which case this is missing a comma between "and options" and "and returns" (or you could wrap "which takes a url and options" in parens).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how that's confusing! I tried rewriting it a few times and then decided to just document the argument explicitly, I think it's an improvement.