Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-1187 Add Clojure api overview documentation #32

Merged
merged 8 commits into from
Aug 16, 2021

Conversation

dpetran
Copy link
Contributor

@dpetran dpetran commented Aug 10, 2021

No description provided.

Let's not advertise the magic functionality of translating :authors into :book/authors.
@Tr3yb0 Tr3yb0 merged commit b835e8e into main Aug 16, 2021
@Tr3yb0 Tr3yb0 deleted the task/add-clojure-api-docs branch August 16, 2021 14:15
@dpetran
Copy link
Contributor Author

dpetran commented Aug 17, 2021

Are there any more blockers on this PR?

@Tr3yb0
Copy link
Contributor

Tr3yb0 commented Aug 18, 2021

nope i thought when i merged it, it closed the PR.. the changes have been pushed to the public deploy
We just need to update the clojars -> cljdocs issue for the badge

@dpetran
Copy link
Contributor Author

dpetran commented Aug 18, 2021

I talked to @cap10morgan about that, I'm closing the pom.xml PR (#84) and we'll explore using tools.build to generate the correct pom sometime in the future.

@Tr3yb0
Copy link
Contributor

Tr3yb0 commented Aug 19, 2021

Ok, I am going to remove the badge from the page then. We can add it back when we get everything set up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants