Skip to content

Add :remote conn type to connect to fluree/server #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

bplatz
Copy link
Contributor

@bplatz bplatz commented Aug 17, 2023

This for #431 this adds a :remote conn type that takes a list of fluree/server addresses and can execute queries against a remote server network.

This adds core library support, so it can be used in any app using the library, or it is also used by fluree/server to establish a server as an edge query-server.

This PR does not contain the message broadcasting (auto-updating remote dbs), which will be in a separate PR to keep things slim.

@bplatz bplatz requested a review from a team August 17, 2023 15:37
Copy link
Contributor

@zonotope zonotope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔉


conn-proto/iConnection
(-close [_]
(log/info "Closing memory connection" id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "Closing remote connection"

(storage/resolve-index-node conn node
(fn [] (conn-cache/lru-evict lru-cache-atom cache-key))))))))

#?@(:clj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just not implement the protocol here instead of implementing it and throwing an unsupported exception on the only method.

@bplatz bplatz merged commit 2746c2e into main Aug 17, 2023
@bplatz bplatz deleted the feature/remote-conn branch August 17, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants