WIP feat: recent trades API #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lispc
commented
Jan 20, 2021
•
lispc
commented
- recent trades API
- make startall / make viewlogs / make stopall
- store enum as str in db
- some fixes of kline
- some fixes of db
|
I will add quote_amount and taker_side into TradeRecord, which are useful for recent trades & ticker |
I think quote_amount = amount / price? It would be a tradeoff of space and time. |
ChrisLinn
reviewed
Jan 20, 2021
quote_amount = amount * price. Sum of quote amount is widely used, so storing it will be better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.