Skip to content

fix: highlight only the line under the pointer - #1959

Open
KapJI wants to merge 3 commits into
fluidd-core:developfrom
KapJI:fix/thermal-chart-hover
Open

KapJI wants to merge 3 commits into
fluidd-core:developfrom
KapJI:fix/thermal-chart-hover

Conversation

@KapJI

@KapJI KapJI commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Depends on #1958, which is the first commit here; the second is this change.

Since #1858, hovering the temperature chart makes it flash. Whenever the pointer lands on a line, a symbol or an area, emphasis.focus: 'series' dims every other series, and on the next move the axis pointer highlights all of them again, so the chart keeps switching between one line and all of them. Between lines nothing is focused, so each line needs careful aiming.

The series are now silent, which alone stops the flashing. Hovering a sensor in the Thermals card still highlights its series as before.

On top of that, I propose widening the visible line nearest to the pointer (within 16 px, interpolated between samples, keeping its dash pattern) as a nicer highlight. It is a setOption, so it re-syncs the axis pointer as #1958 does after data updates. If you would rather not have it, I can remove it, leaving only the tooltip on chart hover.

Rows hover works as before.

Before:

thermal-chart-hover-before-github.mp4

After (HOVER_WIDTH_INCREASE=1):

thermal-chart-hover-width-1-github.mp4

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Bundle size report (gzip)

Chunk Base Head Δ
assets/Dashboard-*.js 63.2 kB 63.8 kB +671 B
assets/index-*.js 161.1 kB 161.1 kB -6 B
sw.js 11.2 kB 11.2 kB +4 B
assets/Timelapse-*.js 1.9 kB 1.9 kB -3 B
assets/Tune-*.js 3.4 kB 3.4 kB -3 B
assets/AppBtnCollapseGroup-*.js 640 B 638 B -2 B
assets/Diagnostics-*.js 15.9 kB 15.9 kB -2 B
assets/GcodePreview-*.js 366 B 368 B +2 B
assets/Icons-*.js 530 B 528 B -2 B
assets/Jobs-*.js 501 B 499 B -2 B
assets/Settings-*.js 23.3 kB 23.3 kB -2 B
assets/AppColorPicker-*.js 13.0 kB 13.0 kB -1 B
assets/Console-*.js 366 B 365 B -1 B
assets/DiskUsageCard-*.js 3.2 kB 3.2 kB -1 B
assets/GcodePreviewCard-*.js 13.2 kB 13.2 kB +1 B
assets/History-*.js 3.8 kB 3.8 kB +1 B
assets/JobHistoryItemStatus-*.js 1.2 kB 1.2 kB -1 B
assets/MacroCategorySettings-*.js 2.0 kB 2.0 kB -1 B
assets/NotFound-*.js 438 B 437 B -1 B
assets/TimelapseRenderSettingsDialog-*.js 1.8 kB 1.8 kB -1 B
Total 2.9 MB 2.9 MB +650 B

119 chunks compared, 20 changed. Sizes are gzip, matching what nginx serves.

@KapJI
KapJI force-pushed the fix/thermal-chart-hover branch from e2208f7 to a7fe8af Compare September 19, 2026 23:02
Signed-off-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
pedrolamas and others added 2 commits September 23, 2026 10:15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
@KapJI
KapJI force-pushed the fix/thermal-chart-hover branch from 0333c38 to de6ba7e Compare September 23, 2026 12:35
@KapJI

KapJI commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and decreased HOVER_WIDTH_INCREASE from 1.5 to 1, I think it looks nicer this way.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants