Repository navigation
Conversation
Bundle size report (gzip)
119 chunks compared, 20 changed. Sizes are gzip, matching what nginx serves. |
KapJI
force-pushed
the
fix/thermal-chart-hover
branch
from
September 19, 2026 23:02
e2208f7 to
a7fe8af
Compare
Signed-off-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
KapJI
force-pushed
the
fix/thermal-chart-hover
branch
from
September 22, 2026 18:07
a7fe8af to
0333c38
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
KapJI
force-pushed
the
fix/thermal-chart-hover
branch
from
September 23, 2026 12:35
0333c38 to
de6ba7e
Compare
Contributor
Author
|
Rebased and decreased |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1958, which is the first commit here; the second is this change.
Since #1858, hovering the temperature chart makes it flash. Whenever the pointer lands on a line, a symbol or an area,
emphasis.focus: 'series'dims every other series, and on the next move the axis pointer highlights all of them again, so the chart keeps switching between one line and all of them. Between lines nothing is focused, so each line needs careful aiming.The series are now
silent, which alone stops the flashing. Hovering a sensor in the Thermals card still highlights its series as before.On top of that, I propose widening the visible line nearest to the pointer (within 16 px, interpolated between samples, keeping its dash pattern) as a nicer highlight. It is a
setOption, so it re-syncs the axis pointer as #1958 does after data updates. If you would rather not have it, I can remove it, leaving only the tooltip on chart hover.Rows hover works as before.
Before:
thermal-chart-hover-before-github.mp4
After (
HOVER_WIDTH_INCREASE=1):thermal-chart-hover-width-1-github.mp4