Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThermalChart): consistent chart color on single device #1522

Merged
merged 8 commits into from
Nov 9, 2024

Conversation

pedrolamas
Copy link
Member

A few updates on the thermal chart:

  • For the same device (eg. Extruder), use the same color in the chart for Temperature, Target, Power, and Speed
  • Change the chart data suffixes in use from Target, Power, and Speed to #target, #power, and #speed (avoids collision with device name as # is used for comments and thus, not allowed)
  • Refactor the legend toggle code (fixes a possibility of having Temperature and Target state out of sync)

Fixes #1462

Signed-off-by: Pedro Lamas pedrolamas@gmail.com

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added the GH - Bug Something isn't working label Nov 8, 2024
@pedrolamas pedrolamas added this to the 1.31 milestone Nov 8, 2024
@pedrolamas pedrolamas merged commit f217cd4 into fluidd-core:develop Nov 9, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/fix-thermals branch November 9, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thermals Power % Graph Line Colors not in Legend
1 participant