Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLUID-6782, FLUID-6771: fixes contrast themes with blocking theme and base styles #1110

Merged
merged 6 commits into from
Dec 3, 2024
Merged

FLUID-6782, FLUID-6771: fixes contrast themes with blocking theme and base styles #1110

merged 6 commits into from
Dec 3, 2024

Conversation

jobara
Copy link
Member

@jobara jobara commented Nov 25, 2024 •
edited
Loading

  • fixes bug where blocking theme didn't fully isolate the separate panel from contrast theme changes
  • fixes bug where separated panel wasn't styled properly after preference changes when only the base styles are used
  • refactored .fl-inverted-color styling to swap foreground/background instead of recreating all of the theme styling rules
  • added:
    • --fl-linkFgColor
    • --fl-linkBgColor
    • --fl-disabledFgColor
    • --fl-disabledBgColor
  • deprecated:
    • --fl-linkColor
    • --fl-disabledColor
    • sass (.scss) files
  • Added manual test for using UIO with only base styles

Related PRs

This was referenced Nov 25, 2024
Merged
Merged
@jobara jobara requested a review from greatislander November 26, 2024 01:14
@jobara jobara mentioned this pull request Nov 30, 2024
Merged
@jobara jobara merged commit 9dfe6ec into fluid-project:main Dec 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatislander greatislander greatislander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jobara @greatislander