Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluent-bit image to 2.0.4 #279

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Update fluent-bit image to 2.0.4 #279

merged 1 commit into from
Nov 9, 2022

Conversation

iamleot
Copy link

@iamleot iamleot commented Nov 8, 2022

Closes #274.

Signed-off-by: Leonardo Taccari leonardo@faire.ai

@iamleot iamleot changed the title Update image to 2.0.3 Update fluent-bit image to 2.0.3 Nov 8, 2022
@iamleot iamleot marked this pull request as ready for review November 8, 2022 15:46
@edsiper
Copy link
Member

edsiper commented Nov 8, 2022

FYI: we are shipping 2.0.4 right now

@iamleot
Copy link
Author

iamleot commented Nov 8, 2022

FYI: we are shipping 2.0.4 right now

Whoops, I've missed that!

If no candidate PR is prepared for the Helm chart I can adjust this one to update to 2.0.4 instead!

Thank you @edsiper!

@stevehipwell
Copy link
Collaborator

@edsiper is there anything which would need to change to support v2? Is YAML GA yet (if not where can I feedback on it as the use of arrays is problematic)?

I'm still planning on splitting the charts out into collector and aggregator variants so major work can happen then.

@edsiper
Copy link
Member

edsiper commented Nov 8, 2022

@braunsonm
Copy link

@stevehipwell YAML is still problematic with arrays, see fluent/fluent-bit#5446
Workaround works there.

When YAML goes GA it would be good to have better support in the chart for it (currently you need to override the start params and use a custom config file)

@iamleot iamleot marked this pull request as draft November 8, 2022 21:40
@iamleot
Copy link
Author

iamleot commented Nov 8, 2022

Moving back to draft... adjusting to actually update to 2.0.4 and pushing with the force! Updated to 2.0.4.

@iamleot iamleot changed the title Update fluent-bit image to 2.0.3 Update fluent-bit image to 2.0.4 Nov 8, 2022
@iamleot iamleot marked this pull request as ready for review November 8, 2022 21:43
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @iamleot, just one comment for you to take a look at.

charts/fluent-bit/Chart.yaml Outdated Show resolved Hide resolved
@stevehipwell
Copy link
Collaborator

@iamleot I'm going to try and merge a couple of other PRs before yours as the current automation is very noisy and it'd be best to get the noise out of the way before the v2 chart release. You might need to rebase once they're done but I'll comment back here when you can do it without needing to do so multiple times.

@stevehipwell
Copy link
Collaborator

Just waiting for #278.

@iamleot iamleot marked this pull request as draft November 9, 2022 19:49
@stevehipwell
Copy link
Collaborator

@iamleot could you rebase this now?

Closes #274.

Signed-off-by: Leonardo Taccari <leonardo@faire.ai>
@stevehipwell
Copy link
Collaborator

@iamleot do you want to remove the draft status?

@iamleot iamleot marked this pull request as ready for review November 9, 2022 21:43
@iamleot iamleot requested review from stevehipwell and removed request for edsiper and naseemkullah November 9, 2022 21:44
@iamleot
Copy link
Author

iamleot commented Nov 9, 2022

@iamleot do you want to remove the draft status?

Yeah, I was waiting for the GitHub Actions workflows checks to complete to avoid possible further notification spamming!

I have rebased to latest main and hopefully addressed all the comments!

If there is anything else please let me know!

Thank you very much!

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit 32f0fbf into fluent:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fluent-bit to v2
4 participants