-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fluent-bit image to 2.0.4 #279
Conversation
FYI: we are shipping 2.0.4 right now |
Whoops, I've missed that! If no candidate PR is prepared for the Helm chart I can adjust this one to update to Thank you @edsiper! |
@edsiper is there anything which would need to change to support v2? Is YAML GA yet (if not where can I feedback on it as the use of arrays is problematic)? I'm still planning on splitting the charts out into collector and aggregator variants so major work can happen then. |
|
@stevehipwell YAML is still problematic with arrays, see fluent/fluent-bit#5446 When YAML goes GA it would be good to have better support in the chart for it (currently you need to override the start params and use a custom config file) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @iamleot, just one comment for you to take a look at.
@iamleot I'm going to try and merge a couple of other PRs before yours as the current automation is very noisy and it'd be best to get the noise out of the way before the v2 chart release. You might need to rebase once they're done but I'll comment back here when you can do it without needing to do so multiple times. |
Just waiting for #278. |
@iamleot could you rebase this now? |
Closes #274. Signed-off-by: Leonardo Taccari <leonardo@faire.ai>
@iamleot do you want to remove the draft status? |
Yeah, I was waiting for the GitHub Actions workflows checks to complete to avoid possible further notification spamming! I have rebased to latest If there is anything else please let me know! Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #274.
Signed-off-by: Leonardo Taccari leonardo@faire.ai