Repository navigation
Backport(v1.19): in_tail: extract periodic file discovery into DirWatcher (#5554) - #5559
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
**Which issue(s) this PR fixes**: None. **What this PR does / why we need it**: Move existing path expansion and watcher reconciliation into an included DirWatcher module without changing behavior. Keep lifecycle ordering and per-file watcher operations in TailInput. A follow-up PR will add event-based directory watching. This refactoring prepares for that feature by grouping the existing discovery logic, without adding directory events or new settings. **Docs Changes**: None. **Release Note**: This is an internal refactoring with no intended behavior change. Assisted-by: LLM GPT-6.1 Sol (OpenAI) Signed-off-by: Takuro Ashie <ashie@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5554
None.
What this PR does / why we need it:
Move existing path expansion and watcher reconciliation into an included
DirWatcher module without changing behavior. Keep lifecycle ordering and
per-file watcher operations in TailInput.
A follow-up PR will add event-based directory watching. This refactoring
prepares for that feature by grouping the existing discovery logic, without
adding directory events or new settings.
Docs Changes:
None.
Release Note:
This is an internal refactoring with no intended behavior change.
Assisted-by: LLM GPT-6.1 Sol (OpenAI)