test: ensure removing old engine on setup #5057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continued from 6cac9f0. Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
added
CI
|
Thanks for your review! |
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Sep 10, 2025
**Which issue(s) this PR fixes**: Continued from * fluent#5054 * fluent#5055 (6cac9f0) **What this PR does / why we need it**: Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Sep 11, 2025
**Which issue(s) this PR fixes**: Continued from * fluent#5054 * fluent#5055 (6cac9f0) **What this PR does / why we need it**: Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Sep 11, 2025
**Which issue(s) this PR fixes**: Continued from * fluent#5054 * fluent#5055 (6cac9f0) **What this PR does / why we need it**: Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Sep 11, 2025
**Which issue(s) this PR fixes**: Continued from * fluent#5054 * fluent#5055 (6cac9f0) **What this PR does / why we need it**: Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
added a commit
that referenced
this pull request
Sep 11, 2025
…5085) **Which issue(s) this PR fixes**: * Backport #5057 Continued from * #5054 * #5055 (6cac9f0) **What this PR does / why we need it**: Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Continued from
What this PR does / why we need it:
Each test should not consider the initialization of
Fluent::Engine.It should be the responsibility of
Fluent::Test.setup.Note: Set
nilexplicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist afterremove_constandGC.start.Docs Changes:
Not needed.
Release Note:
CI improvements.