Backport(v1.16): Add fiddle as dependency gem for Ruby 3.5 on Windows (#4869) #4919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Since Ruby 3.5, `fiddle` gem was marked as bundled gem. ruby/ruby@10ecdeb This patch will fix following warning on Windows Ruby 3.4 and fix load error on Windows Ruby 3.5: ``` C:/hostedtoolcache/windows/Ruby/3.4.2/x64/lib/ruby/gems/3.4.0/gems/serverengine-2.4.0/lib/serverengine/winsock.rb:21: warning: fiddle/import is found in fiddle, which will no longer be part of the default gems starting from Ruby 3.5.0. You can add fiddle to your Gemfile or gemspec to silence this warning. ``` FYI) `fiddle` has been used in https://github.com/fluent/fluentd/blob/f1f0bb2474ed8d4f7b6011a321a2b93e3b1dd9cb/lib/fluent/win32api.rb#L21-L22 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Watson1978
approved these changes
Apr 24, 2025
|
Hmm, do we need this for v1.16 series? |
|
If any users want to install using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #4869
Fixes #
What this PR does / why we need it:
Since Ruby 3.5,
fiddlegem was marked as bundled gem.ruby/ruby@10ecdeb
This patch will fix following warning on Windows Ruby 3.4 and fix load error on Windows Ruby 3.5:
FYI)
fiddlehas been used influentd/lib/fluent/win32api.rb
Lines 21 to 22 in f1f0bb2
Docs Changes:
Release Note: