parser: use URI#open instead of URI.open #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

daipom merged 1 commit into fluent:master from Watson1978:parser

Mar 6, 2025

Contributor

Watson1978 commented Mar 5, 2025 •

edited by daipom

Loading

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

By CodeQL documentation, it is safer to avoid using URI.open.
This is a false positive, so there is no impact on Fluentd.
(Because URI.parse checks the uri in advance.)

Docs Changes:

Release Note:

Watson1978 force-pushed the parser branch 4 times, most recently from 6819ef7 to aaf54d3 Compare

March 5, 2025 08:46

Watson1978 marked this pull request as ready for review

March 5, 2025 09:23

Watson1978 requested a review from daipom

March 5, 2025 09:23

Watson1978 added the backport to LTS label

daipom added this to the v1.19.0 milestone

Watson1978 force-pushed the parser branch from aaf54d3 to 836a05d Compare

March 6, 2025 02:55

Watson1978 mentioned this pull request

v1_parser: use URI#open instead of URI.open #4854

Merged

Watson1978 force-pushed the parser branch from 836a05d to fff0145 Compare

March 6, 2025 06:20

daipom reviewed

View reviewed changes

Contributor

daipom left a comment

Thanks!

Basically, it looks good to me.
I commented on a few points. Please check them.

lib/fluent/config/parser.rb Outdated Show resolved Hide resolved

lib/fluent/config/parser.rb Outdated Show resolved Hide resolved

lib/fluent/config/parser.rb Outdated Show resolved Hide resolved


          parser: use URI#open instead of URI.open

c1b5055

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Watson1978 force-pushed the parser branch from fff0145 to c1b5055 Compare

March 6, 2025 07:51

daipom approved these changes

View reviewed changes

Contributor

daipom left a comment

Thanks!

daipom merged commit 4b23d40 into fluent:master

9 of 10 checks passed

Watson1978 deleted the parser branch

March 6, 2025 09:10

daipom pushed a commit that referenced this pull request


          v1_parser: use URI#open instead of URI.open (#4854)

ccf5768

**Which issue(s) this PR fixes**: 
Fixes #

**What this PR does / why we need it**: 
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with #4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

Watson1978 mentioned this pull request

parser: fix file path into URI#open for Windows #4855

Merged

daipom pushed a commit that referenced this pull request


          parser: fix file path into URI#open for Windows (#4855)

3a4ef4c

**Which issue(s) this PR fixes**: 
Fixes #

**What this PR does / why we need it**: 
This patch will fix the problem in
#4848
`u.path` has the file path without a drive letter in Windows
environment.

If Fluentd is worked on `c` drive and config file exists in `d` drive,
it can't parse config file, I think.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          v1_parser: use URI#open instead of URI.open (fluent#4854)

4f7cf08

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with fluent#4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: use URI#open instead of URI.open (fluent#4848)

dadd301

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          v1_parser: use URI#open instead of URI.open (fluent#4854)

29e5cd7

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with fluent#4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: use URI#open instead of URI.open (fluent#4848)

19fd45f

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          v1_parser: use URI#open instead of URI.open (fluent#4854)

5a3d6ef

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with fluent#4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: use URI#open instead of URI.open (fluent#4848)

bb4acc2

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          v1_parser: use URI#open instead of URI.open (fluent#4854)

13d334c

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with fluent#4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys mentioned this pull request

Backport(v1.16): v1_parser: use URI#open instead of URI.open (#4854) kenhys/fluentd#12

Closed

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: use URI#open instead of URI.open (fluent#4848)

423e318

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys mentioned this pull request

Backport(v1.16): parser: use URI#open instead of URI.open (#4848) kenhys/fluentd#13

Closed

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          v1_parser: use URI#open instead of URI.open (fluent#4854)

97fd165

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with fluent#4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys mentioned this pull request

Backport(v1.16): v1_parser: use URI#open instead of URI.open (#4854) #4921

Merged

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: use URI#open instead of URI.open (fluent#4848)

622d7bb

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys mentioned this pull request

Backport(v1.16): parser: use URI#open instead of URI.open (#4848) #4922

Merged

daipom pushed a commit that referenced this pull request


          Backport(v1.16): v1_parser: use URI#open instead of URI.open (#4854) (#…

47b126b

…4921)

**Which issue(s) this PR fixes**: 
Backport #4854
Fixes #

**What this PR does / why we need it**: 
By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

This is similar with #4848

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>

daipom pushed a commit that referenced this pull request


          Backport(v1.16): parser: use URI#open instead of URI.open (#4848) (#4922

5f95d70

)

**Which issue(s) this PR fixes**: 
Backport #4848
Fixes #

**What this PR does / why we need it**: 

By [CodeQL
documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/),
it is safer to avoid using `URI.open`.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>

kenhys added the backported label

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: fix file path into URI#open for Windows (fluent#4855)

fd546bc

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
This patch will fix the problem in
fluent#4848
`u.path` has the file path without a drive letter in Windows
environment.

If Fluentd is worked on `c` drive and config file exists in `d` drive,
it can't parse config file, I think.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

This was referenced Apr 24, 2025

Backport(v1.16): parser: fix file path into URI#open for Windows (#4855) kenhys/fluentd#16

Closed

Backport(v1.16): parser: fix file path into URI#open for Windows (#4855) kenhys/fluentd#18

Closed

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: fix file path into URI#open for Windows (fluent#4855)

8bd51fd

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
This patch will fix the problem in
fluent#4848
`u.path` has the file path without a drive letter in Windows
environment.

If Fluentd is worked on `c` drive and config file exists in `d` drive,
it can't parse config file, I think.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys mentioned this pull request

Backport(v1.16): parser: fix file path into URI#open for Windows (#4855) kenhys/fluentd#20

Closed

kenhys pushed a commit to kenhys/fluentd that referenced this pull request


          parser: fix file path into URI#open for Windows (fluent#4855)

7a3fe79

**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
This patch will fix the problem in
fluent#4848
`u.path` has the file path without a drive letter in Windows
environment.

If Fluentd is worked on `c` drive and config file exists in `d` drive,
it can't parse config file, I think.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys mentioned this pull request

Backport(v1.16): parser: fix file path into URI#open for Windows (#4855) #4926

Merged

daipom pushed a commit that referenced this pull request


          Backport(v1.16): parser: fix file path into URI#open for Windows (#4855…

36095d3

…) (#4926)

**Which issue(s) this PR fixes**: 
Backport #4855
Fixes #

**What this PR does / why we need it**: 
This patch will fix the problem in
#4848
`u.path` has the file path without a drive letter in Windows
environment.

If Fluentd is worked on `c` drive and config file exists in `d` drive,
it can't parse config file, I think.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to LTS backported