in_tail: reduce the lifespan of the buffer area #4763
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
changed the title
daipom
pushed a commit
that referenced
this pull request
Mar 26, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Previous, I changed lifespan of `iobuf` at #4763 to work GC collector well. In addition, it seems that clearing `iobuf` manually when it is no longer needed, it might improve memory efficiency.  * config ``` <source> @type tail path "#{File.expand_path '~/tmp/access*.log'}" pos_file "#{File.expand_path '~/tmp/fluentd/access.log.pos'}" tag log refresh_interval 5s <parse> @type none </parse> </source> <match **> @type file path "#{File.expand_path '~/tmp/log'}" </match> ``` * script to generate log data ``` require "json" path = File.expand_path("~/tmp/access.log") File.open(path, "w") do |f| loop do log = { time: Time.now, message: "a" * 10_000 }.to_json f.puts log sleep 0.05 end end ``` Related to #4808 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
When log files are rotated at high speed, the lifespan of
IOHandlerobjects may become extended.Along with this, the lifespan of
@iobufalso increases.Since
@iobufuses 8 KB of memory, if many such objects exist simultaneously, memory usage might significantly increase.Docs Changes:
Release Note: