in_tail: Fix warning log about overwriting entry with follow_inodes #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
ashie
approved these changes
Jun 23, 2023
|
Thanks! |
|
TODO: We need to apply it to v1.16 branch too. |
daipom
deleted the
in_tail-fix-warning-overwriting-entry-with-follow_inodes
branch
|
Thanks for your review! |
OK! Shall I make the PR? |
I made it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
This fixes the following warning message:
Even when
follow_inodeswas enabled, this message was displayed based on the path.This PR fixes it.
In addition, this PR slightly fixed this message when
follow_inodesis enabled.Docs Changes:
No need because this fixes only the log message.
Release Note:
Same as the title.