Skip to content

CI: Reduce log level on Windows #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Mar 14, 2023

Which issue(s) this PR fixes:
None

What this PR does / why we need it:
For some reason, the log level is Debug only on Windows.
This makes it harder to find failing tests.

Docs Changes:
Not needed.

Release Note:
Not needed.

For some reason, the log level is Debug only on Windows.
This makes it harder to find failing tests.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@ashie
Copy link
Member

ashie commented Mar 15, 2023

IMHO I want to leave it as is for a while.

On Windows some tests often become unstable due to other test's state although it shouldn't be.
When I investigate them, I often check which tests are executed before failed tests.
In fact I recently noticed a problem which is caused by a past unrelated pull request.

It might be hard to find if -v isn't specified:

@daipom
Copy link
Contributor Author

daipom commented Mar 15, 2023

I see! Thanks for the explanation!
Now I understand the benefits of this setting.
I close this.

@daipom daipom closed this Mar 15, 2023
@ashie
Copy link
Member

ashie commented Mar 15, 2023

BTW for finding failed test I search Failure: or Error: (including former & later spaces) with case sensitive.
It makes easy to find failed tests even if -v is added or not.

@daipom
Copy link
Contributor Author

daipom commented Mar 15, 2023

Thanks!!
Do you use View raw logs and then search the words?

@ashie
Copy link
Member

ashie commented Mar 15, 2023

I use both Web UI and raw logs.

@daipom
Copy link
Contributor Author

daipom commented Mar 15, 2023

I see! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants