Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Object.__send__ to avoid conflicting method name #2614

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Sep 11, 2019

Which issue(s) this PR fixes:
Fixes #2613

What this PR does / why we need it:

Use Object.__send__ to avoid conflicting method name

Docs Changes:

no need

Release Note:

same as the title

@repeatedly
Copy link
Member

All test failed. Could you check it?

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Copy link
Member

@repeatedly repeatedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ganmacs ganmacs merged commit 9a7d512 into fluent:master Sep 11, 2019
@ganmacs ganmacs deleted the use-__send__ branch September 11, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining a send method on a plugin causes failure on shutdown
2 participants