Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of ERB warning for Ruby 2.6+ #2430

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Conversation

k0kubun
Copy link
Contributor

@k0kubun k0kubun commented May 31, 2019

Which issue(s) this PR fixes: None

What this PR does / why we need it: I found lots of ERB.new warnings (ruby/ruby@cc777d09f44) in https://travis-ci.org/fluent/fluentd/jobs/539499703 and I thought it'd be annoying.

Docs Changes: None

Release Note: Suppress deprecation warnings of ERB for Ruby 2.6+

Signed-off-by: Takashi Kokubun <takashikkbn@gmail.com>
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd written previously similar patch but I didn't have enough confidence to fix this. ❤️

@repeatedly repeatedly merged commit 63383cd into fluent:master Jun 1, 2019
@repeatedly
Copy link
Member

Thanks!

@k0kubun k0kubun deleted the erb-warning branch June 1, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants