Expose the current list of timekeys as a buffer metric #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for monitoring things like: - How old is the current oldest log message still in the buffer? - Equivalently, what is the maximum latency of the logging system as a whole? This might be interesting to track over time. - How new is the *newest* log message in the buffer? This might indicate a delay upstream of fluentd. Signed-off-by: Steven McDonald <steven.mcdonald@usabilla.com>
stevenjm
force-pushed
the
timekey-metrics
branch
from
61ace46
to
8d37c85
Compare
|
The initial test failure doesn't look related to my change. I've force pushed the same commit with an updated timestamp to re-run the CI. |
|
Looks good for me. @cosmo0920 How about this? |
|
Also looks good to me. 😄 |
|
Thx! |
stevenjm
added a commit
to usabilla/fluent-plugin-prometheus
that referenced
this pull request
May 29, 2019
A metric listing all timekeys in each buffer was added to fluentd in <fluent/fluentd#2343>. This exports the oldest and newest values in that list as Prometheus metrics. See discussion in <fluent#89> for context and rationale.
stevenjm
added a commit
to usabilla/fluent-plugin-prometheus
that referenced
this pull request
May 29, 2019
A metric listing all timekeys in each buffer was added to fluentd in <fluent/fluentd#2343>. This exports the oldest and newest values in that list as Prometheus metrics. See discussion in <fluent#89> for context and rationale. Signed-off-by: Steven McDonald <steven.mcdonald@usabilla.com>
stevenjm
added a commit
to usabilla/fluent-plugin-prometheus
that referenced
this pull request
Aug 7, 2019
A metric listing all timekeys in each buffer was added to fluentd in <fluent/fluentd#2343>. This exports the oldest and newest values in that list as Prometheus metrics. See discussion in <fluent#89> for context and rationale. Signed-off-by: Steven McDonald <steven.mcdonald@usabilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is useful for monitoring things like:
Docs Changes:
None of the existing
buffer_*metrics appear to be documented, so there doesn't seem to be a sensible place to document this.Release Note:
A new
buffer_timekeysmetric provides a list of timekeys currently in the buffer when time-based chunking is enabled.