Create pos file directory if it doesn't exist #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
adammw
force-pushed
the
adammw/create-pos-file-dir
branch
from
6189be8
to
e568e23
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently encountered an issue where the subdirectory the
pos_fileshould be written to didn't exist, causing the in_tail plugin to emit an exception and crash fluentd, resulting in a crash loop. The process had permission to write to the parent directory so it could have easily created the directory and avoided an outage. This change adds a mkdir_p call to create the directory if it detects that the directory the pos_file is in doesn't exist./cc @repeatedly