in_http: Prefer parser's time_key setting in batch. fix #2018 #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
cosmo0920
approved these changes
Jun 21, 2018
test/plugin/test_in_http.rb
Outdated
| @@ -162,6 +162,29 @@ def test_multi_json_with_time_field | |||
| assert_equal_event_time time, d.events[1][1] | |||
| end | |||
|
|
|||
| def test_multi_json_with_time_key | |||
There was a problem hiding this comment.
test_multi_json_with_time_key seems to be testing for existent time_key.
I perfer to use test_multi_json_with_nonexistent_time_key or test_multi_json_with_missing_time_key for test case name.
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
|
Apply review. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.