Add parameter delimiter_pattern to parser_ltsv #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature is taken from https://github.com/fluent-plugins-nursery/fluent-plugin-kv-parser fluent-plugin-kv-parser is very simple and similar to parser_ltsv. So we can integrate fluent-plugin-kv-parser with parser_ltsv.
repeatedly
reviewed
Dec 26, 2017
lib/fluent/plugin/parser_ltsv.rb
Outdated
| desc 'The delimiter character between field name and value' | ||
| config_param :label_delimiter, :string, default: ":" | ||
|
|
||
| config_set_default :time_key, 'time' | ||
|
|
||
| def parse(text) | ||
| r = {} | ||
| text.split(@delimiter).each do |pair| | ||
| delimiter = @delimiter_pattern || @delimiter |
There was a problem hiding this comment.
How about moving this to configure?
There was a problem hiding this comment.
Thank you for reviewing. Good catch.
Because `#parse` is called for each event. On the other hand `#configure` is called once on boot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is taken from
https://github.com/fluent-plugins-nursery/fluent-plugin-kv-parser
fluent-plugin-kv-parser is very simple and similar to parser_ltsv.
So we can integrate fluent-plugin-kv-parser with parser_ltsv.