Move tick check to after heartbeat for avoiding the impact of other node heartbeat. fix #1719 #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode heartbeat. fix #1719
|
@mururu Could you check this change? |
|
Looks good. |
repeatedly
added a commit
that referenced
this pull request
Nov 14, 2017
Move tick check to after heartbeat for avoiding the impact of other node heartbeat. fix #1719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, fluentd supports only UDP heartbeat and it uses async check between fluentd nodes.
So if previous node takes longer time for heartbeat, it doesn't affect elapsed time.
On the other hand, recent fluentd supports TCP heartbeat and it uses sync check via tcp connection.
So if previous node takes longer time, it affects elapsed time for current node and it causes misjudgment.
To avoid the problem, elapsed time calculation should be done after heartbeat.